BIND 10 #2184: adding and removing items to/from lists/dicts for item_type=='any'

[BIND 10 Development]

#2184: adding and removing items to/from lists/dicts for item_type=='any'
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:  bind-  |             Sensitive:  0
  ctl                                |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Looking at the code, it seems it's OK and blends well into the surrounding
 code.

 However, I noticed few things that may be some debugging leftovers:
 {{{#!diff
 -                item_name =  isc.cc.data.parse_value_str(value_str)
 +                #item_name =  isc.cc.data.parse_value_str(value_str)
 +                item_name = value_str
 }}}

 {{{#!diff
                  value, status = self.get_value(identifier)
 -                if status == self.NONE and not
 spec_part['item_optional']:
 +                if status == self.NONE and not
 spec_part['item_optional']:# and\
 +                   #not ('item_default' in spec_part):
                      raise isc.cc.data.DataNotFoundError(identifier + "
 not found")
 }}}

 This one, what does it print? When I'm guessing what should go out, I
 think the sentence might need some verb or so somewhere.
 {{{#!python
 raise isc.cc.data.DataNotFoundError(str(identifier) + " is not a list or a
 named_set " + str(module_spec) + " and type " + str(type(cur_value)))
 }}}

 I think these are small things, so if you can have a look at them before
 tomorrow morning, I think I can still review them before I leave.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2184#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development