BIND 10 #2164: Introduce RRset::getRRsigDataCount()

BIND 10 Development do-not-reply at isc.org
Mon Aug 13 16:45:14 UTC 2012


#2164: Introduce RRset::getRRsigDataCount()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 muks]:

 > > The change removes this line from the testdata Makefile.am:
 > > EXTRA_DIST += message_toWire4.spec message_toWire5.spec
 > >
 > > I assume that is an accident :)
 >
 > Eek! Fixed. :)
 >
 > > The dynamic cast in the added test in message_unittest makes me think
 that this new method should probably go into the AbstractRRset interface
 as well.
 >
 > I wondered where to put it as well, as the RRSIGs are really handled
 only in the `RRset` class. But you tipped the balance in `AbstractRRset`'s
 favour. :) It also avoids the `dynamic_cast`, so I agree this is better.

 Ah, actually, it was the intent.  It's intended to be defined in the
 abstract base class from the beginning.  Maybe the subject line was
 not really clear.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2164#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list