BIND 10 #2137: update the boss module according to the new statistics model

[BIND 10 Development]

#2137: update the boss module according to the new statistics model
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120821
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  statistics                         |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => jelte


Comment:

 Hello, thank you for the good explanation.

 Since #2136, #2137, and #2138, the protocol between the stats module and
 other target module is widely changed. Could you refer to #2135 and the
 wikipage StatsModule for details of this wide change?

 In the new codes, the stats module asks each module to send back
 statistics data. The target module can return only statistics data which
 were contents of the ''data'' argument before.

 Since the stats module knows the name of the target module, the target
 module doesn't need to inform its name to the stats module, that is, the
 ''owner'' argument wasn't needed. But only in the boss case, this
 ''owner'' actually made no sense before, and the stats module required it.

 In #2136, the stats module checks the format of statistics data returned
 from the target module by using the method
 ''isc.conf.module_spec.validate_statistics()''. If it fails, the stats
 module logs an error and continues to run.

 All fixes to the stats module for this change will be done on #2136. For
 looking the both behaviors of the new stats module and the new boss,
 merging trac2136 into trac2137 is needed. #2136 is going on reviewing, but
 I've now merged trac2136 into trac2137 and pushed into the remote branch.
 Could you review that codes again?:-)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2137#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development