BIND 10 #2097: Define and Implement RdataSet class

[BIND 10 Development]

#2097: Define and Implement RdataSet class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 The code looks fine, and can be merged. I have a few minor suggestions,
 which you can take or leave :)


 given the nature of this beast, I think it should be explicitely
 noncopyable. In effect compilers will fail on stack-allocation due to the
 private destructor, but I think it would be a bit cleaner to also use
 boost::noncopyable.

 Also, I wonder if convertRRTTL() should be a native public method of the
 RRTTL class, it sounds reasonable to have a way to get it in wire format
 (or have it as a util function an make writeUint32 use it too). Not that
 it's complicated code or anything, so no strong opinion, but it does seem
 to go against the DRY principle)

 And some additional test suggestions:

 createManyRRs: perhaps also try with a count more than 8192 (to make sure
 the code uses > not == 8192 in its check)

 manyRRSigCount: ditto (but obviously with something more than 65536), also
 perhaps since we check that the magic number 7 is used here, check that
 MANY_RRSIG_COUNT is 7?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2097#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development