BIND 10 #2178: Logging for Out-of-zone data

[BIND 10 Development]

#2178: Logging for Out-of-zone data
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Ready for review, I've added an optional argument to masterLoad() for even
 better error messages, and the configurableclientlist now specifically
 catches masterload errors. It simply logs them and continues (so that
 other datasources/zones still work).

 I have found two additional things for which I have a patch, but have not
 included it in this branch;
 - the config update hack in auth's main.cc (line 205) appears to be
 unnecessary; an update is immediately called anyway.
 - a potentially bigger problem that is shown by this ticket is that
 reconfigure() in the DataSourceConfigurator can throw, which it shouldn't,
 as it is used as a remote config callback; we should probably catch and
 log std::exception and maybe even (...) as well (in
 reconfigureInternal()).

 I can add them or create a separate ticket.

 Proposed changelog:
 [bug]
 b10-auth no longer exits upon encountering a zone content problem (such as
 out-of-zone data) in configured MasterFiles zones. It only logs an error,
 and all other zones and datasources are still loaded. The error log
 message has been improved to include the zone origin and source file name.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2178#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development