BIND 10 #2165: update Message::addRRset() to be unaware of signedness

[BIND 10 Development]

#2165: update Message::addRRset() to be unaware of signedness
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120904
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:7 jinmei]:
 > And one final thing at this moment: I think in database.cc we should
 > avoid including RRSIGs from the beginning if they are not required.
 > I believe we can do the trick in getRRsets().  Then we won't have to
 > do expensive stripRRsigs() (in general, if we need explicitly do
 > things like in any other place than in the current in-memory
 > implementation I think it's not the correct way).

 This has been fixed now. :)

 > One other thing: this won't work because rrset_to_delete now wouldn't
 > have RRSIGs.
 >
 > {{{#!python
 >         self.assertRaises(isc.datasrc.Error, updater.delete_rrset,
 >                           rrset_to_delete)
 > }}}
 >

 Thanks for noticing this, esp. the tip that tests are run out of order.
 The results are printed out of order too and I was looking at a later
 failure assuming it was the cause. Running the unittests with
 `verbosity=2` made it more obvious what was going on. We should bump
 minimum required Python to 3.2 and add `verbosity=2` to all unittests so
 it prints the test names as it's executing them.

 The bug has been fixed now. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2165#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development