BIND 10 #2100: Update ZoneTable class

[BIND 10 Development]

#2100: Update ZoneTable class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120904
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 General:

 The unit tests didn't compile for me;
 {{{
 zone_table_unittest.cc: In member function ‘virtual void
 {anonymous}::ZoneTableTest_create_Test::TestBody()’:
 zone_table_unittest.cc:83:16: error: variable ‘table’ set but not used
 [-Werror=unused-but-set-variable]
 }}}

 I pushed a commit that removes that variable.

 I also pushed a trivial commit that updates the copyright year in the new
 files to 2012 :)


 zone_table.h:

 class ZoneTable; IIRC, we had agreed that we'd use boost:noncopyable
 instead of making the copy constructor and assignment operators private.

 For the rest it looks ok, though I did notice one mostly unrelated
 potential issue in labelsequence::serialize() which is triggered in the
 new unit tests (via resetLabels()); I think the memcpy there
 (labelsequence.cc:110) should be a memmove, as the regions are quite
 likely to overlap

-- 
Ticket URL: <http://bind10.isc.org/ticket/2100#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development