BIND 10 #2178: Logging for Out-of-zone data
BIND 10 Development
do-not-reply at isc.org
Fri Aug 24 15:50:17 UTC 2012
#2178: Logging for Out-of-zone data
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: jinmei
Type: | Status: reviewing
defect | Milestone:
Priority: | Sprint-20120904
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 3
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:7 jelte]:
> > Possible minor issues:
> > - `MasterLoadError` can only happen from here:
> > {{{#!cpp
> > if (type == "MasterFiles") {
> >
finder->load(paramConf->get(*it)->stringValue());
> > }}}
> > so we can narrow the try block.
>
> Yes, originally i had narrowed it, but then you do get an empty added
zone (since the 'zonefinder' object is still added. Which would be solved
by either checking that it succeeded, or doing cache->addZone() it in both
branches. I did the latter for now, and narrowed the try.
This looks okay, so please feel free to merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2178#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list