BIND 10 #2096: Define and implement "RdataReader" class
BIND 10 Development
do-not-reply at isc.org
Fri Aug 24 16:46:00 UTC 2012
#2096: Define and implement "RdataReader" class
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120904
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
scalable inmemory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:21 vorner]:
I noticed some documentation was lost from rdata_field.h, so I
recovered it. I made a few minor changes, too (one was necessary for
clang).
One last thing, I'd note we intentionally name
rdata_serialization_priv.cc as ".cc" (not .h) here:
{{{#!cpp
// This file is directly included from the rdata_serialization.cc. It
would
// be part of the file if we didn't need to steal some definitions from
here
// for the tests (which include it too).
}}}
(assuming that was indeed the intent).
Other than this it looks okay. Please feel free to merge (I don't
think I need to review the revised comment about .cc, in case you make
it).
--
Ticket URL: <http://bind10.isc.org/ticket/2096#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list