BIND 10 #2157: Create an interface to pass statistics counters in Auth module

[BIND 10 Development]

#2157: Create an interface to pass statistics counters in Auth module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  y-aharen                           |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  8
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I've read some part of the branch, but I now think it's better to
 review this stuff after #2154 is completed (or at least after we are
 sure what to do with it).

 Here are some intermediate comments, which may or may not matter
 depending on the #2154 discussion:

 '''auth_srv'''

 - get()/dump() are too generic.  I'd rename them, e.g.,
   getStatistics(), dumpStatistics(), etc.
 - Similarly, the description is quite ambiguous:
 {{{#!cpp
     /// \brief Get the values of specified counters.
     ///
     /// This function returns names and values of counter.
 }}}
   For example, it's not clear what "counters" means.
 - Description for get/dump doesn't seem to be sufficient in general.
   Need to describe parameters; describe in which case an exception is
   thrown, describe return value in more detail, and maybe describe the
   overall method behavior in more detail.
 - the const in the return type for get/dump is meaningless:
 {{{#!cpp
     const isc::auth::statistics::Counters::item_tree_type get(
         const isc::auth::statistics::Counters::item_node_name_set_type&
 items)
         const;
 }}}
   If you intended something like `const TreeType*` by this, what we
   should do is to define item_tree_type as `ConstElementPtr`
   (and then remove the unnecessary const).  Same comment applies to
   the `Counters` class.

 '''statistics.h'''
 - item_tree_type does not seem to be aligned with our type naming
   convention.  It would normally be named `ItemTreeType`.
   same for item_node_name_type and item_node_name_set_type.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2157#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development