BIND 10 #2179: Update Stats to support differential statistics updates
BIND 10 Development
do-not-reply at isc.org
Mon Aug 27 14:13:22 UTC 2012
#2179: Update Stats to support differential statistics updates
-------------------------------------+-------------------------------------
Reporter: | Owner: naokikambe
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20120904
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DNS
statistics | Estimated Difficulty: 8
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => naokikambe
Comment:
First of all, i'd be clear and talk about 'partial' rather than
'differential' data.
Changelog:
- see above (differential->partial)
- and a few language improvements; i propose:
The stats module now supports partial statistics updates. Each
module can return only statistics data which have been updated since
the last time it sent them to the stats module. The purpose of partial
updates is to reduce the amount of statistics data sent through the
message queue.
And a side note: it's easier to propose a changelog ticket here (on trac)
rather than through the branch, as it will most certainly cause an
unnecessary conflict (just add it when you merge), and you'll need to
update it to get the commit id anyway.
But since it's there I have a comment, we use tabs instead of 8 spaces :)
stats.py.in:
in merge_oldnew(), I'd check whether the types are the same, and raise an
error if they arent (i'm guessing you could have some pretty unexpected
results if they are not, for some reason, as you then just drop the old).
Also, I wonder if the lists version is useful; if they are of different
length, can you be sure that the shorter list is the same as the start of
the longer list?
--
Ticket URL: <http://bind10.isc.org/ticket/2179#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list