BIND 10 #2165: update Message::addRRset() to be unaware of signedness

[BIND 10 Development]

#2165: update Message::addRRset() to be unaware of signedness
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120904
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  2.91
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:17 jinmei]:
 > > > `setTTL()` is eventually called by the `Message` class on the passed
 `RRset`.
 >
 > How exactly?  At least in the new API `Message` shouldn't have to
 > modify the passed RRsets for responses.  As for setTTL(), I cannot
 > even find a code path in `Message` where setTTL() happens in the
 > rendering mode.

 Ah, my bad. Both `fromWire()` and `toWire()` use the same `rrsets_` array,
 and this happens in the `fromWire()` case. We can refactor this code to
 `const` and non-`const` parts so `Message::addRRset()` takes `const`, but
 it would be larger than a trivial change and outside the scope of this
 bug. Let's open another bug for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2165#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development