BIND 10 #2166: update RRset::toWire() so it will render RRSIGs, too

[BIND 10 Development]

#2166: update RRset::toWire() so it will render RRSIGs, too
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  closed
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120904
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to master in commit `5d1e19947ce5875cd950f1b1750dad5076909446`:
 {{{
 * 79f1c5b (origin/trac2165_2) [2165] Remove effects that were used during
 EDNS testing
 * 1159e5b [2165] Test RRType::RRSIG() query when FIND_DNSSEC is not passed
 * abcd7d9 [2165] Fix answer section count in comment
 * 2fabaed [2165] Don't continue and render RRSIGs if data is truncated
 * 11af4c1 [2165] Add TODO to commented out test code
 * 33ab70a [2165] Update comment
 * a173297 [2165] Move ZoneFinder::stripRRsigs() into a .cc file
 * 3afbf54 [2165] Rename variables
 * 552c578 [2165] Remove another block of redundant code
 * 3c20e03 [2165] Ignore RRSIG database records if sigs argument is false
 * 32dd44a [2165] Rename member variable to contain underscore
 * a8d00ea [2165] Fix typo in comment
 * 94d0fd2 [2165] updater.delete_rrset no longer raises (as there are no
 attached RRSIGs now)
 * 1fbbeb3 [2165] Stop RRSIGs from being added in getRRsets() itself
 * 7f00956 [2165] Don't strip RRSIGs from DNSSEC rrsets
 * 9a13449 [2165] Remove RRSIG filtering code from getAdditionalAddrs()
 * 2a22df2 [2165] Check for NULL rrsets in stripRRsigs() itself
 * 52f1d2c [2165] Remove multiple copies of the same code
 * 18324f0 [2165] Fix NSEC3 tests to expect RRSIGs in some more cases
 * 98a0dad [2165] Fix NSEC3 tests to expect RRSIGs in some cases
 * f060129 [2165] Strip RRSIGs in MockZoneFinder when DNSSEC find option is
 not specified
 * ef85853 [2165] Strip RRSIGs from addditional records in DB datasource
 when DNSSEC is not asked
 * 4ecd5fb [2165] Don't add another copy of RRSIGs to the actual rrsets
 * cdfbc35 [2165] Strip RRSIGs from addditional records in memory
 datasource when DNSSEC is not asked
 * d057be8 [2165] Add the attached RRSIG when dumping RRsets
 * 525a74d [2165] Disable test code that is no longer correct
 * 8cc84c6 [2165] Add back deleted dnssec flag in some places
 * 5438673 [2165] Update prepareRRset() to filter RRSIGs when
 ZoneFinder::FIND_DNSSEC is not passed
 * 4c86091 [2165] Disable some datasrc tests which cover obsolete API
 * c4500a6 [2166] Update RRset::toWire() so it will render RRSIGs too
 * ace794f [2165] Make Message::addRRset() to be unaware of signedness
 }}}

 Resolving as fixed. Thank you for the reviews Michael and Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2166#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development