BIND 10 #357: There should be timeout on TCP connection in auth server

[BIND 10 Development]

#357: There should be timeout on TCP connection in auth server
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  b10-auth                           |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  0
            Defect Severity:         |
  Medium                             |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 About the changelog message, it looks bad if it starts with lower-case
 letter, maybe changing the sentence slightly so b10-auth is not the first
 word? Also, maybe saying the well-known word „Timeout“ in there somewhere
 might make sense.

 Now, to the code. Cppcheck complains here:
 src/bin/auth/auth_config.cc:123: check_fail: Member variable
 'TCPRecvTimeoutConfig::timeout_' is not initialized in the constructor.
 (warning,uninitMemberVar)

 The special-case of 0 should be documented in the guide.

 Maybe we should also validate the value is non-negative (someone might try
 to put -1 there hoping for some magic to happen). Also, maybe a warning
 with too low values (below 1 second, for example)?

 Also, I'm not sure if 1 is enough as a default value. There are connection
 types (like GPRS/EDGE) with possibly multi-second round trips.

-- 
Ticket URL: <https://bind10.isc.org/ticket/357#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development