BIND 10 #2506: Specialized getNextToken interface for

[BIND 10 Development]

#2506: Specialized getNextToken interface for
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121204
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:7 jelte]:

 > master_lexer_unittests.cc:
 >
 > eolCheck() expects a particular sequence of tokens, so it'd be nice if
 this got a small comment (either pointing out which tests it is intended
 for or which tokens it should get, i.e. the two consecutive newlines)

 Okay, I added some more comments.

 > Regarding that, I think the 'skip the 2nd \n' can go into eolCheck :)

 Yeah I was aware of that, and I don't remember why I chose not to
 do so - maybe it was because it didn't look a job of "check".  But
 with some more detailed comments that now doesn't seem to be a concern
 anyway, so I unified it in eolCheck().

 > Oh and one additional test could be for another bad number case, where
 initially it does look like a number (e.g. '123abc'), for instance
 [...]
 > (this does not necessarily test anything extra, but given the way tokens
 are recognized I do believe this is a potentially useful addition)

 Okay, added.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2506#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development