BIND 10 #2497: introduce wrapper version of "from lexer" rdata factory
BIND 10 Development
do-not-reply at isc.org
Tue Dec 4 02:32:07 UTC 2012
#2497: introduce wrapper version of "from lexer" rdata factory
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20121204
Sub-Project: DNS | Resolution:
Estimated Difficulty: 0 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:24 muks]:
> > So, for example, if we have ('xxx', 'generic') in
new_rdata_factory_users,
> > we need to handle the case of ('xxx', 'in'), too. One easy way to
> > just clarify it in the comment (after all this is temporary
> > workaround). Another is to handle it automatically in
generate_rrparam().
>
> I've updated the code to handle this, and also verified it with a
`[('soa', 'generic')]` sample list, which also applies it to the `('soa',
'in')` case.
Change looks okay, but not very readable (and one line is too long).
I've committed a suggested fix to that. I also added one example
for the 'generic' class.
HINFO changes seem overkill (we'll soon discard them anyway), but
don't look incorrect so I'm okay with them.
So, if the suggested changes to the script are okay please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2497#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list