BIND 10 #2497: introduce wrapper version of "from lexer" rdata factory
BIND 10 Development
do-not-reply at isc.org
Tue Dec 4 06:13:30 UTC 2012
#2497: introduce wrapper version of "from lexer" rdata factory
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | closed
Component: libdns++ | Milestone:
Keywords: | Sprint-20121204
Sensitive: 0 | Resolution: fixed
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 2
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* status: reviewing => closed
* resolution: => fixed
Comment:
Merged to `master` in commit `d5f52afdc5419756f514f79ecd53f59090555c43`:
{{{
* 203b4a0 [2497] some suggested editorial cleanups: long line, identation,
better e.g.
* 20ff1f4 [2497] Apply generic rules to class IN too
* ec24cb1 [2497] Add a direct HINFO testcase for the string parser
* 1a2787f [2497] Fix HINFO parsing in the string parser
* 7237139 [2497] Return whether the string is quoted in
characterstr::getNextCharacterString()
* 3e5f225 [2497] Remove a couple of txt tests
* 947a2d7 [2497] Move repeated code to a function
* 292db14 [2497] Make new_rdata_factory_users[] a list of tuples
* 8ab540a [2497] constify
* 45b4e93 [2497] Return NULL upon exception in rdata::createRdata()
* 9e98b47 [2497] Add tests for NSEC3PARAM-like rrtypes
* 43292d6 [2497] Add tests for NSEC3PARAM, DS-like and TXT-like rrtypes
* e3afa9c [2497] Add tests for NSEC3, NSEC and TSIG rrtypes
* c73280d [2497] Also check and stop at END_OF_LINE
* 1c4683d [2497] Add tests for AFSDB, DHCID and DNSKEY rrtypes
* 25f6513 [2497] Add tests for HINFO, MINFO and NAPTR rrtypes
* 5c8cd40 [2497] Add tests for OPT, PTR and RP rrtypes
* 3563065 [2497] Add tests for RRSIG, SOA and SRV rrtypes
* 41754f4 [2497] Refactor RRSIG rrtype test code
* 5e0e2e5 [2382] corrected trivial syntax error in #2497
* 2b8518d [2497] Add a comment for RRParamRegistryTest.createFromLexer
* 022d388 [2497] Add rdata::createRdata() and tests for some RRtypes
* aac7b17 [2497] Move create() definition to .cc file
* 6921ae3 [2497] Add missing testcase for AbstractRdataFactory::create()
from lexer
* 331d377 [2497] Add a new RdataFactory class which includes the new
create() impl
* e980e67 [2497] Delete trailing whitespace
* 0bfb997 [2497] Rename existing RdataFactory to OldRdataFactory
* 1b66148 [2497] Introduce a new AbstractRdataFactory::create() that takes
a MasterLexer
* 1051eb4 [2497] Add placeholder MasterLoader class
* 79968a2 [2497] Fix #endif comment to match #if comment
}}}
I've verified that lettuce also passes after merge to master.
Resolving as fixed. Thank you for the reviews Jinmei.
--
Ticket URL: <https://bind10.isc.org/ticket/2497#comment:28>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list