BIND 10 #2382: introduce generic version of rdata::createRdata(text)

[BIND 10 Development]

#2382: introduce generic version of rdata::createRdata(text)
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121204
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Again, it looks good, only some minor comments:

 rdata.h:

 There is a small error in the doxygen for the createRdata method:
 'it can use pass a callback that'
 (I guess the 'use' should be removed)

 master_lexer.cc:

 In the Number::handle() method, the push_back('\0') calls could now be
 unified outside of the if-statement


 rdata_unittest.cc:

 Suggestion for one more test: an rr with a comment at the end of the line,
 e.g. aaaa_rdata.toText() << " ;comment"
 To make sure comments are not treated as 'extra input'

-- 
Ticket URL: <http://bind10.isc.org/ticket/2382#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development