BIND 10 #2377: define dns::MasterLoad class

[BIND 10 Development]

#2377: define dns::MasterLoad class
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121204
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  7             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 It is ready for review. The first two commits
 (425e18f7045e7300230bb2876d69a1ec9837a6bd,
 3a81d2d941bb7f8be0219cc2ec4176c894634237) are just merges of the branches
 it
 depends on (#2506, #2382) and are not interesting for review.

 I did a quick look into the bind9 code and was scared about the 1500 lines
 long
 function full of gotos. I hope we can avoid it with the OOP approach ‒
 especially the exceptions could help. The current code is definitely
 shorter,
 and I think the flexibility and $ handling can be at least put into a
 separate
 method. Also the fact that we don't collate the RRsets could make it
 slightly
 simpler.

 The code itself contains several TODO notes, but I think they are all
 objectives of other tickets.

 I don't think this ticket itself needs a changelog entry. We probably
 should
 have something covering the whole new master loader framework once it is
 done,
 but I'd wait for it when we have the other missing bits.

 About the tickets to update, I think the rest is not affected much. The
 master
 loader is directly used by the zone loader, and I'll update it to match
 that in
 a moment, but I don't know if anything else uses master loader itself.

 We probably do want a ticket for the collator of RRs to RRsets, but I
 don't
 think we need it written right away ‒ we need to update the in-memory data
 source to accept scattered RRsets anyway and the database already supports
 merging naturally. But I'm going to create the ticket once we conclude the
 review.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2377#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development