BIND 10 #2534: support minor cases for quoted character strings

BIND 10 Development do-not-reply at isc.org
Wed Dec 5 04:29:03 UTC 2012


#2534: support minor cases for quoted character strings
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  new
                       Type:  task   |             Milestone:  Next-Sprint-
                   Priority:         |  Proposed
  medium                             |              Keywords:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
               CVSS Scoring:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 In #2442 I noticed the current (design and) implementation of
 `MasterLexer` is not fully compatible with BIND 9 in some minor cases.
 One symptom is shown in the commented-out test of
 `Rdata_TXT_LIKE_Test::createMultiStringsFromText` added in #2442.

 To be compatible with BIND 9 (and in this case we should be compatible
 based on the basic policy that we do so unless there's a reason for
 not doing so), we need:

 - include '"' as a separator built in `MasterLexerImpl`:
 {{{#!cpp
         separators_.set('\r');
         separators_.set('\n');
         separators_.set(' ');
         separators_.set('\t');
         separators_.set('(');
         separators_.set(')');
 }}}
 - treat it as an error if '"' is encountered in `State::start` and
   the `MasterLexer::QSTRING` option isn't specified.

 We'll need to do adjust some test cases.

 Also, I suspect we first need to complete #2498; otherwise adjusting
 the tests will be more difficult.

 Note also that we won't recognize quoted string as a STRING type of
 token (a string including quotation marks themselves) any more.  This
 will require doc update.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2534>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list