BIND 10 #2378: define and implement datasrc::ZoneLoader class
BIND 10 Development
do-not-reply at isc.org
Fri Dec 7 13:16:26 UTC 2012
#2378: define and implement datasrc::ZoneLoader class
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: jelte
Type: task | Status:
Priority: medium | reviewing
Component: data source | Milestone:
Keywords: | Sprint-20121218
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 4 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jelte
Comment:
Hello
Replying to [comment:5 jelte]:
> I have no problems with the doxygen changes, but we may want to swing it
past Jeremy (and/or merge it separately).
Hmm, is doxygen documentation part of „public“ release? Or is it internal
for developers?
But I have no problem with asking him to have a look. I'll ask him right
away.
> May be a matter of taste, but from the looks of it, loadIncremental
could simply put 'return (complete_);' at the end, instead of separate
returns for each branch. And following that, it could also pull out the
commit, making it
Hmm, good point.
> Oh and I found one other corner case (though this should probably belong
to 2377): loading an empty file succeeds, and I think it should fail
('empty as in no rrsets, and mainly, no SOA). Not sure if this would be
considered something validate() would do, just noting that currently it is
accepted :)
The ZoneLoader is mostly a glue class only, so I don't think it belongs
into
it. The MasterLoader probably doesn't have this responsibility either. So
I
think it should be the validate().
--
Ticket URL: <http://bind10.isc.org/ticket/2378#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list