BIND 10 #2353: write tests for all methods of Bob
BIND 10 Development
do-not-reply at isc.org
Tue Dec 11 03:14:47 UTC 2012
#2353: write tests for all methods of Bob
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: defect | Status:
Priority: medium | closed
Component: Boss of BIND | Milestone:
Keywords: | Sprint-20121218
Sensitive: 0 | Resolution: fixed
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 8 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 6.5
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* status: reviewing => closed
* resolution: => fixed
Comment:
Pushed to `master` branch in commit
`c0be62cb0f27a0855c007beabeb0c3ba3c4fb0ff`:
{{{
* 3e2d8b0 [2353] Update comments (recommended by review)
* 32011f9 [2353] Rename and document BoB._run_under_unittests
* 02f306c [2353] Unify repeated test code
* 6af3de2 [2353] Use a test environment instead of an empty one
* 366f210 [2353] Use assertRaises() instead of the excessive code
* e6ebe1d [2353] Check that BoB.start_msgq() calls isc.cc.Session() and
group_subscribe()
* de66fdd [2353] Test BoB.startup() when socket already exists
* cdbe6de [2353] Remove unused assignments
* 029ac58 [2353] Rename variable
* e8a23d3 [2353] Remove run_under_unittests hack from BoB.start_cfgmgr()
* f7e3012 [2353] Make DummySession() return a real message in
group_recvmsg()
* 4f80651 [2353] Restore isc.config.ModuleCCSession during tearDown()
* 87cd15b [2353] Restore time.time() and time.sleep() during tearDown()
* 3c17e95 [2353] Unify verbose and non-verbose cases
* bae03c0 [2353] Don't call real sleep() in mock function
* ec4581d [2353] Check if msgq_socket_file is carried over in
BoB.startup()
* 70db0c5 [2353] Change assertion type for dict
* 609e5bf [2353] Explain why we throw after 15 recv()s, in a comment
* 71cf0a2 [2353] Test the env string in various tests
* 40d54f7 [2353] Test the values of component registered by
BoB.register_process()
* 30e529a [2353] Make test more deterministic
* f1035ba [2353] Use assertRaises() instead of the excessive code
* 0740a5d [2353] Check an environment string in BoB.start_msgq() test
* 045d32e [2353] Check BoB.get_processes() return value as a list
* eba06ee [2353] Use assertIn() in some places
* 93d27cb [2353] Check BoB.components_to_restart as a list
* 8a966b8 [2353] Update syntax used, combining two statements into one
* 2c2459f [2353] Rewrite code that depended on BoB.start_ccsession()
returning a value
* 145a4ed [2353] Don't run block of code when requested not to by
unittests
* 41ccdad [2353] Use a flag instead of overriding BoB.wait_time
* 8682cdc [2353] Add description for BoB._make_process_info()
* 0688fdb [2353] Use a flag instead of overriding BoB.msgq_timeout
* cfdfb58 [2353] unrelated cleanup: removed an obsolete comment.
* 08a5a3d [2353] style fixes: folded long lines
* 7f6ecb5 [2353] style fix: folded a long line
* f6c776b [2353] Update comments
* bc4926d [2353] Test BoB.startup()
* fa3e24b [2353] Test BoB._socket_data() directly
* a11abf3 [2353] Indent comment
* 996d6ff [2353] Test BoB.start_cfgmgr() timeout checks
* 924c7a4 [2353] Restore the saved time.time function
* 8cb9e9e [2353] Don't check an upper bound on number of attempts
* f117a66 [2353] Test BoB.start_msgq() timeout checks
* 77c012c [2353] Test BoB.start_ccsession()
* d514212 [2353] Fix an error in comments
* a9ebc37 [2353] Test options for BoB.start_cfgmgr()
* 1ab0c5a [2353] Test defaults for BoB.start_cfgmgr()
* 15249e5 [2353] Test BoB.start_msgq()
* da089cd [2353] Remove obsolete comments
* 5450b25 [2353] Use a MockProcessInfo to test BoB.start_process()
* b1c8e1c [2353] Test various combinations of booleans in
BoB.reap_children()
* 58f0aac [2353] Test unknown pids in BoB.reap_children()
* 84fbdae [2353] Simply assertFalse() for the list
* 09f21f4 [2353] Test exception handling in BoB.reap_children()
* 36d2b84 [2353] Test port arg in BoB.start_cmdctl()
* 4f52e89 [2353] Test verbose case of BoB.start_cmdctl()
* c2c64ea [2353] Test verbose case of BoB.start_resolver()
* 230de14 [2353] Test verbose case of BoB.start_auth()
* 54a707d [2353] Remove the digit suffix from tests
* 51bd304 [2353] Rename MockBob2 to MockBobSimple
* da1b2d7 [2353] Rewrite test_start_simple() to use MockBob2
* d5c0c97 [2353] Test verbose case of BoB.start_simple()
* a7b31b7 [2353] runnable doesn't have to be set here
* 7503458 [2353] Directly use bob.components instead of
bob.get_processes()
* 37da25f [2353] Just check the output of get_processes() is empty (as a
boolean)
* 0f228f2 [2353] Check that kill_started_components() forcefully kills
components
* 8b31b93 [2353] runnable doesn't have to be set here
* f9445ff [2353] runnable doesn't have to be set here
* 494bbca [2353] Ensure that get_processes() returns a sorted list
* 67f4798 [2353] Check remove_socket_srv() with different states of
BoB._srv_socket
* 32e8885 [2353] Ensure that the server listens on the socket
* 9d23c50 [2353] Check that getsockname() on the socket returns what we
expect
* 83d4f41 [2353] Test that the socket and tmpdir are deleted
* 424b8d8 [2353] Test bind10_src.fatal_signal()
* 3590bad [2353] Test bind10_src.get_signame()
* 4a9b794 [2353] Test BoB.init_socket_srv() and BoB.remove_socket_srv()
* 180a437 [2353] Test more component startup methods
* 6210dae [2353] Add test for BoB.start_simple()
* 6b8c62a [2353] Add test for BoB.register_process()
* b0db66c [2353] Add test for BoB.start_process()
* 7173928 [2353] Add test for BoB.kill_started_components()
* 7ba306a [2353] Add test for BoB.get_processes()
* 9b6c74f [2353] Indent code
* 356a8b2 [2353] Test BoB.reap_children
}}}
Also pushed to `master` branch post-merge to fix for new code in `master`
(reviewed by Jinmei on Jabber):
{{{
* 230ccce (trac2353) [master] Clear components dict as documented in
BoB.kill_started_components()
}}}
Resolving as fixed. Thank you for the reviews Jinmei.
--
Ticket URL: <http://bind10.isc.org/ticket/2353#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list