BIND 10 #2470: use MasterLoader in memory::ZoneDataLoader

BIND 10 Development do-not-reply at isc.org
Tue Dec 11 04:19:26 UTC 2012


#2470: use MasterLoader in memory::ZoneDataLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  accepted
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac2470 is ready for review.

 I introduced a new generic class in libdns++ that collates RRs produced
 by `MasterLoader` into RRsets, and then updated the datasrc internal
 implementation uses these new classes instead of masterLoad().

 The essentially initial commit (50ca8b1) is an unrelated cleanup
 to avoid repeating the same pattern in tests.

 The main parts of the branch of is the implementation of the new
 collator class: from 7a2d5ea to bd87756.

 The last commit is the update to the in-memory data source (with one
 trivial change to test data).  This is quite small and should be
 trivial.

 Maybe this ticket needs a changelog.  I'm okay with either way, but if
 we want to add one, this is the proposed text:
 {{{
 520.?   [func]*         team
         The in-memory data source now uses a more complete master file
         parser to load textual zone files.  As of this change it supports
         multi-line RR representation and more complete support for escaped
         and quoted strings.  It also produces more helpful log when there
         is an error in the zone file.  It will be enhanced as the
         MasterLoader class is extended.  The new parser is generally upper
         compatible to the previous one, but due to the tighter checks
         some input that has been accepted so far could now be rejected,
         so it's advisable to check if you use textual zone files directly
         loaded to memory.
         (Trac #2470, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2470#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list