BIND 10 #2270: Configuration parser for DHCPv4 server

BIND 10 Development do-not-reply at isc.org
Wed Dec 12 11:10:43 UTC 2012


#2270: Configuration parser for DHCPv4 server
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcpconf      |                    Milestone:
            Keywords:                |  Sprint-DHCP-20121213
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tomek


Comment:

 '''config_parser.cc'''
 '''Order of header files...''': Stephen recently reordered headers in all
 (or most of the) files. In the config_parser.cc boost includes are still
 before project includes. I think it may be good idea to reorder them to be
 consistent with the rest of the DHCP code.

 '''namespace''': Since the parser classes are not meant to be called from
 an outside world they could be stored in unnamed namespace rather than
 isc::dhcp. I admit that this would require a lot of refactoring in the
 present code so it may be deferred for now. Maybe until we merge the V4
 and V6 config parsers.

 Apart from this it is ok and can be merged (I don't have to see the code
 if you just reorder headers).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2270#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list