BIND 10 #2546: DHCP Lease Manager - miscellaneous updates

[BIND 10 Development]

#2546: DHCP Lease Manager - miscellaneous updates
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20121213
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 There are still some legitimate warnings being reported by cppcheck:

 src/lib/dhcp/pkt4.cc: line 238: redundantCopy: Buffer 'chaddr_' is being
 written before its old content has been used.

 src/lib/dhcp/pkt4.cc: line 260: redundantCopy: Buffer 'file_' is being
 written before its old content has been used.

 src/lib/dhcp/pkt4.cc: line 248: redundantCopy: Buffer 'sname_' is being
 written before its old content has been used.

 src/lib/dhcpsrv/alloc_engine.cc: line 70: Possible inefficient checking
 for 'pools' emptiness.

 src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc: line 472: Function
 parameter 'leases' should be passed by reference.

 I recall that the last one might have been fixed on master already.

 ----

 There is also one cppcheck warning that does not seem to be valid:
 src/bin/dhcp6/tests/config_parser_unittest.cc: line 100: Variable 'first'
 is assigned a value that is never used.

 The value is used in the subsequent iterations of the loop and could be
 suppressed.

 ----

 Other changes seem to be ok.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2546#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development