BIND 10 #2428: support $INCLUDE in dns::MasterLoader

[BIND 10 Development]

#2428: support $INCLUDE in dns::MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20121218
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:7 jelte]:
 > Any specific reason why source_count_ is kept separately and not through
 size() in the internal vector? (something like
 MasterLexer::getSourceCount() { return impl_->sources.size() })

 Just very specific laziness on my side when I was writing it. Updated.

 > I don't think BIND9 does this either, but I wonder if we should consider
 limiting the number of $includes that can be nested. One would run out of
 open files quite quickly if a zone file includes itself, but we may want
 to catch that before the system does (so we can error with 'too many
 nested includes' rather than 'too many open files').

 I think we may want to leave it out for now. There are two reasons for
 that,
 one is it isn't very much needed yet (the fact that bind9 doesn't do it
 probably means noone asked for it). The other, what would be the best
 number of
 nested includes to limit? So, maybe some time in future?

-- 
Ticket URL: <https://bind10.isc.org/ticket/2428#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development