BIND 10 #2428: support $INCLUDE in dns::MasterLoader

BIND 10 Development do-not-reply at isc.org
Thu Dec 13 20:21:56 UTC 2012


#2428: support $INCLUDE in dns::MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 yeah case insensitivity is checked in the tests

 >
 > > I don't think BIND9 does this either, but I wonder if we should
 consider limiting the number of $includes that can be nested. One would
 run out of open files quite quickly if a zone file includes itself, but we
 may want to catch that before the system does (so we can error with 'too
 many nested includes' rather than 'too many open files').
 >
 > I think we may want to leave it out for now. There are two reasons for
 that,
 > one is it isn't very much needed yet (the fact that bind9 doesn't do it
 > probably means noone asked for it). The other, what would be the best
 number of
 > nested includes to limit? So, maybe some time in future?

 Ok.

 I've pushed two trivial changes/cleanups, please check.

 This branch looks ok and can be merged

-- 
Ticket URL: <http://bind10.isc.org/ticket/2428#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list