BIND 10 #2541: add addZone() interface for data source

BIND 10 Development do-not-reply at isc.org
Thu Dec 13 21:28:13 UTC 2012


#2541: add addZone() interface for data source
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  closed
           Component:  data source   |                    Milestone:
            Keywords:                |  Sprint-20121218
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |  complete
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  11.5          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * hours:  3.5 =>
 * status:  reviewing => closed
 * resolution:   => complete
 * totalhours:  0 => 11.5


Comment:

 Replying to [comment:11 jinmei]:
 > Replying to [comment:10 jelte]:
 >
 > > > I made a few additional minor changes.  Please pull and check them.
 >
 > I made yet another cleanup commit.
 >

 ah duh, thanks :)

 > One final comment:
 >
 > '''sqlite3_accessor_unittest.cc'''
 >
 > Shouldn't rollback be done before the final check?
 > {{{#!cpp
 >     // New zone should not exist
 >     EXPECT_FALSE(accessor->getZone(new_zone).first);
 >
 >     accessor->rollback();
 > }}}
 > I suspect even if another_accessor succeeded to add the zone
 > (e.g. with backend support for more fine-grained lock) the other
 > `accessor` would still not see the new zone unless it exits from the
 > transaction.
 >
 > If I'm correct on this, please make the trivial fix and merge.

 yeah, done.

 Thanks! merged, closing ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2541#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list