BIND 10 #2494: sync_udp_server (asio) gives in under heavy stress

[BIND 10 Development]

#2494: sync_udp_server (asio) gives in under heavy stress
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  1             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  High
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 jelte]:
 > OK, addressed your comments, and put it in a branch.
 >
 > Your mention about that this is for sync mode only made me realize that
 in async we simply ignore any send errors right now. So I tentatively
 pushed a second commit that does a final error_code check at the end of
 the coroutine. If no likey we can leave it out, but it's probably a good
 idea to behave similarly in both setups :)

 Is this `ec` the one passed as a callback for async_send_to due to the
 "coroutine" magic?
 {{{#!cpp
         if (ec) {
             LOG_ERROR(logger, ASIODNS_UDP_ASYNC_SEND_FAIL).
                       arg(data_->sender_->address().to_string()).
                       arg(ec.message());
         }
 }}}
 if so, the branch looks okay (although it looks quite counter
 intuitive...)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2494#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development