BIND 10 #2431: support flexible ordering/appearance of TTL, type and class in dns::MasterLoader
BIND 10 Development
do-not-reply at isc.org
Mon Dec 17 07:22:21 UTC 2012
#2431: support flexible ordering/appearance of TTL, type and class in
dns::MasterLoader
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20121218
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:9 muks]:
> > Finally, a possibly controversial point. As you may have noticed in
> > your review on #2429, I'm concerned about exception overhead when the
> > try-and-error detection for TTL (and RRclass):
[...]
> > And, in that case, my specific suggestion is to merge the branch
> > without this particular optimization (while addressing other issues),
> > leave the ticket open, and complete it in the second phase. (I don't
> > like to delay our meta goal for this optimization, but I'm afraid the
> > optimization part won't be taken if we defer it to a separate ticket.)
>
> I refactored some code so that `RRParamRegistry::textToClassCode()`
onward doesn't throw. These are the three commits for it:
> {{{
> * 693ff3e [2431] Avoid redundant construction in parseRRParams()
> * 3febd2c [2431] Add RRClass.fromText()
> * 3ee0cf2 [2431] Refactor code so that
RRParamRegistry::textToClassCode() does not throw
>
> }}}
>
> Please see if these can go in. If this change is not okay, we can merge
everything up to `3ee0cf2^`.
I suspect you directly modified rrclass.h (which is autogenerated; you
need to edit rrclass-placeholder.h if you want to update rrclass.h)
Or at least forgot to commit/push rrclass-placeholder.h.
--
Ticket URL: <http://bind10.isc.org/ticket/2431#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list