BIND 10 #2470: use MasterLoader in memory::ZoneDataLoader

[BIND 10 Development]

#2470: use MasterLoader in memory::ZoneDataLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:16 jinmei]:
 > I'm not necessarily saying this approach is worse than doing it within
 > the loader, but at least to me it looks equally bad.

 I didn't claim it was elegant. But I think it is slightly less bad than
 doing the check directly in loadIncremental, because:
  * It allows _not_ doing the check, if someone doesn't want it.
  * It adds the complexity to the class, but not to the actual function
 that is
    over-complex by itself. I'd like to push as much complexity outside of
 that
    function, to limit the concentration of the complexity ‒ it might be
 easier
    to get through it in smaller bits.
  * It allows accurate reporting for other kinds of checks. For example, if
    someone wanted do some checks related to their corporate rules
 (checking
    the names include names of departments, for example).  Such checks
    definitely don't belong to the loader and we won't add them there. But
 they
    might want to report the filename and line number for easier fix of the
    problem. So it is nice if we provide a way to do it.

 > You mean the collator calls logger directly?  If so, we cannot do
 > this; libdns++ doesn't use logging directly, intentionally.

 OK, then there's probably nothing more we can do here. Please merge it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2470#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development