BIND 10 #2327: Allocation engine v6: expiration

[BIND 10 Development]

#2327: Allocation engine v6: expiration
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp6         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130103
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 '''src/lib/dhcpsrv/alloc_engine.cc'''[[BR]]
 Suggest a comment at line 210 along the lines of "Hint is in the pool but
 is not available - search the pool until we find a free address of one for
 which the lease has expired"·

 Line 219/220: strictly speaking this comment should be after the following
 "if" statement.

 Line 253: just a note for the future, when we go multiprocess, there could
 be a race condition here - an expired lease is chosen, then some other
 process renews it.  However, we don't have to worry about that now.

 '''src/lib/dhcpsrv/tests/alloc_engine_unittest.cc'''[[BR]]
 Can we move "detailCompareLease6()" into a separate file and share it with
 mysql_lease_mgr_unittests.cc?

 !ChangeLog is OK.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2327#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development