BIND 10 #2507: Cppcheck warnings for version 1.57

[BIND 10 Development]

#2507: Cppcheck warnings for version 1.57
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => UnAssigned
 * status:  assigned => reviewing


Comment:

 Up for review.

 This is a false positive (suppression added):
 {{{
 src/bin/dhcp6/tests/config_parser_unittest.cc:105: check_fail: Variable
 'first' is assigned a value that is never used. (style,unreadVariable)
 }}}

 These have been fixed:
 {{{
 src/lib/cc/data.cc:313: check_fail: Variable 'c' is reassigned a value
 before the old one has been used. (performance,redundantAssignment)
 src/lib/cc/data.cc:400: check_fail: Variable 'i' is reassigned a value
 before the old one has been used. (performance,redundantAssignment)
 }}}

 These are false positives (suppressions added):
 {{{
 src/lib/datasrc/tests/memory/rdata_serialization_unittest.cc:487:
 check_fail: Variable 'current' is reassigned a value before the old one
 has been used. (performance,redundantAssignment)
 src/lib/datasrc/tests/memory/rdata_serialization_unittest.cc:412:
 check_fail: Variable 'current' is assigned a value that is never used.
 (style,unreadVariable)
 src/lib/datasrc/tests/memory/rdata_serialization_unittest.cc:487:
 check_fail: Variable 'current' is assigned a value that is never used.
 (style,unreadVariable)
 }}}

 This code no longer exists:
 {{{
 src/lib/dhcp/tests/libdhcp++_unittest.cc:97: check_fail: Variable
 'factory' is reassigned a value before the old one has been used.
 (performance,redundantAssignment)
 }}}

 I have re-checked with cppcheck 1.57 to verify that these warnings are
 gone.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2507#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development