BIND 10 #2380: revise b10-loadzone using datasrc.ZoneLoader
BIND 10 Development
do-not-reply at isc.org
Wed Dec 19 07:06:01 UTC 2012
#2380: revise b10-loadzone using datasrc.ZoneLoader
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: loadzone | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 8 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:12 jelte]:
> I ran into another test issue; the 'rename-process' test flags b10
-loadzone-ng as bad, it either needs to whitelist it or -ng needs to call
the rename process function like the original (but i think we can just
whitelist it)
Actually, I intended to replace the current loadzone and other
cleanups with the "ng" version with fixing these remaining issues once
other underlying tasks are completed.
Hoping we can merge this version for beta, I made a separate branch:
trac2380merge. It's based on the other tasks, and does the following:
- replace loadzone, and remove now-unrelated files: master.py, some
older tests,
- regression fixes for existing loadzone tests under
loadzone/tests/correct (I confirmed the behavior for the "error"
tests were preserved, and I simply removed the whole tests for that
case)
- one additional fix to the master load implementation as part of the
regression fixes (09dc6a4)
- make it distcheck pass (setting/adjusting environment variables, etc)
- add one other log message (716fd66); see commit log for the intent
Could it get reviewed quickly? I didn't notice you said the original
trac2380 branch can be merged with some small cleanups while I worked
on the "merge" branch, and if you think it's too late to get this
reviewed and merged, I'll merge trac2380 with the name of "-ng" and
keep the current loadzone. If you think it can get reviewed and don't
see substantial issue, please merge it on behalf of me so we can start
buildbot sooner.
I also propose a small update to the proposed changelog:
{{{
530.? [func]* team
b10-loadzone was fully overhauled. It now uses C++-based zone
parser and loader library, performing stricter checks, having
more complete support for master file formats, producing more
helpful logs, more expendable for various types of data
sources, and yet much faster than the old version. In
functionality the new version should be generally backward
compatible to the old version, but there are some
incompatibility: name fields of RDATA (in NS, SOA, etc) must
be absolute in the mean time; due to the stricter checks
some input that was (incorrectly) accepted by the old version
may now be rejected; command line options and arguments are
not compatible.
(Trac #2380, git TBD)
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/2380#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list