BIND 10 #1190: complete logging conversion for msgq

[BIND 10 Development]

#1190: complete logging conversion for msgq
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  msgq          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  5 (for the    |                 CVSS Scoring:
  workaround version)                |              Defect Severity:  Low
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 It is ready for review. Currently, the msgq uses the logging system and
 outputs
 either INFO or DEBUG/99, depending on if -v is provided.

 However, I didn't make it output to file, it outputs to standard output.
 It is
 quite hard to make it output to file, because:
  * The `isc.log.init` doesn't take any parameter that would change it.
  * To call `isc.log.log_config_update`, one needs to have the spec file
 data.
    But to have that, we should be connected to the CC and then, we would
 use
    the usual logging auto-configuration.
  * Updating the wrappers to add a method to modify it sounds like too much
 for
    this workaround ticket, considering the method wouldn't be needed when
 we
    adopt a real approach.
  * Tweaking `B10_LOGGER_` environment variables and then calling
    `isc.log.resetUnitTestRootLogger` sounds like too ugly hack even for
 the
    workaround.

 So, what I propose is merging this ticket as it is (after the review, of
 course), as it provides the conversion of messages. Then we create a new
 ticket
 to connect msgq to itself. I think it should be quite easy:
  * Wait for the ConfigManager to connect and subscribe (otherwise it won't
 work).
  * Create a connection to the socket using common cc library, with
 allowing the
    logging autoconfiguration.
  * Provide an empty handler (or handler with only 'shutdown' command, or
 something).
  * Push the cc file descriptor to the poller/kqueue to watch over.

 Also, this probably calls for a changelog entry:
 {{{
 The b10-msgq now uses the same logging format as the rest of the system.
 However,
 it still doesn't obey the common configuration, as due to technical issues
 it is
 not able to read it yet.
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1190#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development