BIND 10 #2571: type error in data.cc

[BIND 10 Development]

#2571: type error in data.cc
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  new
                       Type:         |             Milestone:  New Tasks
  defect                             |              Keywords:
                   Priority:         |             Sensitive:  0
  medium                             |           Sub-Project:  Core
                  Component:  build  |  Estimated Difficulty:  0
  system                             |           Total Hours:  0
               CVSS Scoring:         |
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 In lib/cc/data.cc, this is not correct:

 {{{#!cpp
     char c = in.peek();
     while (char_in(c, chars) && c != EOF) {
 }}}

 The type of return value of peek() is int, and `c != EOF` is bogus
 (always-true expression) if `char` is unsigned.  Overall variables `c`
 in this file should be defined as int.

 This seems to break ARM build.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2571>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development