BIND 10 #2560: stats crash on cc timeout

[BIND 10 Development]

#2560: stats crash on cc timeout
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  Unclassified  |  Sprint-Proposed
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  Core          |              Defect Severity:  Low
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 A quick proposed patch:
 {{{#!patch
 diff --git a/src/bin/stats/stats.py.in b/src/bin/stats/stats.py.in
 index 7123c53..789c79d 100755
 --- a/src/bin/stats/stats.py.in
 +++ b/src/bin/stats/stats.py.in
 @@ -688,7 +688,8 @@ if __name__ == "__main__":
      except OptionValueError as ove:
          logger.fatal(STATS_BAD_OPTION_VALUE, ove)
          sys.exit(1)
 -    except isc.cc.session.SessionError as se:
 +    except (isc.cc.session.SessionError,
 +            isc.cc.session.SessionTimeout) as se:
          logger.fatal(STATS_CC_SESSION_ERROR, se)
          sys.exit(1)
      except StatsError as se:
 }}}
 I think that error should be caught at  `__main__`. Otherwise it would be
 better that `SessionTimeout` is inherited from `SessionError`?

 BTW suspending is a normal operation? If stats shuts down once, then
 collected statistics are lost. I'm not sure it is ok that stats dies when
 boss is suspended. Otherwise stats should be waiting and doing nothing
 until boss is waked up?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2560#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development