BIND 10 #1190: complete logging conversion for msgq

[BIND 10 Development]

#1190: complete logging conversion for msgq
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  msgq          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  5 (for the    |                 CVSS Scoring:
  workaround version)                |              Defect Severity:  Low
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Since the purpose of the ticket was to get msgq to stop outputting to
 stdout/stderr, I'm not sure if it helps very much to only do the
 conversion (though granted, it is a nice splitup to keep diffs down :))

 So unless we actually REALLY do the followup asap (as in next sprint at
 the latest, and maybe even this one if it turns out there is time left
 (heh)), I would prefer to include it here too.

 If using the ccsession to get config is that easy, it is obviously the way
 to go. An alternative (but also temporary) workaround would be to take the
 approach the new b10-loadzone took; use bind10_config to find the spec
 file and the output path, and create a hardcoded config for logging; for
 instance the attached diff does such a thing (removing the LOG_FILE and
 using the bind10_config.DATA_PATH value, which is essentially the same
 location but also allows some env vars for further modification).

 two small comments on the changes:

 - There is one mismatch between the .mes and the code:
 MSGQ_RECV_INVALID_CMD != MSGQ_INVALID_CMD
 - LOG_FILE is not used.

 BTW, I think we should have another followup ticket to see what actually
 needs to be logged and how, not sure if EOF needs to be an ERROR, for
 instance.

 I also noticed that bind10's -v switch does not translate to msgq's -v
 switch (bind10 -v en/disables msgq output in the first place, but does not
 add -v to msgq call, so starting bind10 -v results in msgq output, but
 only INFO). I was inclined to say that this should be changed, but
 currently it would only add more stdout output instead of remove it (given
 that it would now log to stdout and there are quite a few messages in the
 default logging severity). So if this ticket is still to be merged as-is,
 I'd say the followup ticket(s) need to mention this and update it there.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1190#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development