BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText

BIND 10 Development do-not-reply at isc.org
Wed Dec 26 06:32:08 UTC 2012


#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130108
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:14 jinmei]:
 > Sorry for the interrupt again: I tend to agree that
 > `charStringToString` is a better name than `charStringToStr`,
 > but if we do so, could you change `strToCharString` to
 > `stringToCharString`?  These two functions should be considered as a
 > set, and it's awkward if the naming convention is different.

 It is renamed now.

 Replying to [comment:15 vorner]:
 > > I missed adding a datasrc test.
 >
 > Yes. I guess you'll add it in the next round.

 I tried to add it locally but it doesn't seem to be working (i.e., it
 always manages to pass even without any escaping). I'm going to check
 again what may be wrong.

 > Also, the test currently added, it looks there are bunch of almost the
 same
 > bits, differing just in the character in the middle. Could it be changed
 by a
 > common function, or by a loop and array of data?

 Done now. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list