BIND 10 #2565: Refactor RR param parsing code in MasterLoader

BIND 10 Development do-not-reply at isc.org
Wed Dec 26 06:41:09 UTC 2012


#2565: Refactor RR param parsing code in MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:
                Type:  enhancement   |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jinmei


Comment:

 I follow now what you mean about allocation (on the heap). I agree that
 the single `uint32_t` makes the copy cheap in this case. I want to check
 the performance overhead of `boost::optional` vs. the `new` and if it
 matters in the context of the current code, but when I have time to spend
 on it.

 Please review the code in the branch as it uses `boost::optional` like in
 the `RRTTL` code.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2565#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list