BIND 10 #2480: use real data sources in auth QueryTest

BIND 10 Development do-not-reply at isc.org
Thu Dec 27 21:57:28 UTC 2012


#2480: use real data sources in auth QueryTest
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  accepted
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 It's now ready for review at the trac2480-2 branch (there was a
 "trac2480" branch in the shared repo, but I've rebased it and so
 created a separate new branch for review to avoid confusion; ignore
 the old "trac2480").

 Essentially, this branch only does simple things:

 - use parameterized tests so we can share the same test code with
   multiple data source implementations
 - share the test data: extract the original hardcoded data into a
   unified text source, and generate C++ source file/DNS zone
   file/SQLite3 database file for actual data sources
 - other adjustments to the test cases (tentatively disabling some test
   cases, etc)

 but the resulting diff is quite large, so it may be better to separate
 the review process into two phases: adjustments for non-NSEC3 tests
 (up to commit 2303506 (inclusive)) and the rest (on and after commit
 33ba182).

 Most of the hardcoded data in query_unittest.cc were moved to new
 query_testzone_data*.txt.  The test data were not changed (except for
 adding RRSIGs explicitly).  An added Python script,
 gen-query-testdata.py creates these text files and generates actual
 input for tests.  I guess these occupy most of the diffs, and the rest
 is quite straightforward.

 I found a few real bugs in the data source implementations, for which
 I've disabled corresponding tests for that type of data source.  I'll
 create separate tickets for them.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2480#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list