BIND 10 #2565: Refactor RR param parsing code in MasterLoader

[BIND 10 Development]

#2565: Refactor RR param parsing code in MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:
                Type:  enhancement   |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130108
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by muks):

 Hi Jinmei

 Replying to [comment:11 jinmei]:
 > - I'd change "We return" to "It returns" for consistency:
 > {{{#!cpp
 >     /// We return \c false and avoid simply throwing an exception in the
 >     /// case of an error so that the code is performant in some
 >     /// situations.
 > }}}
 >   I didn't understand this: "the code is performant in some situations".

 I've updated it with this:
 {{{
 -    /// We return \c false and avoid simply throwing an exception in the
 -    /// case of an error so that the code is performant in some
 -    /// situations.
 +    /// It returns \c false and avoids throwing an exception in the case
 +    /// of an error to avoid the exception overhead in some situations.
 }}}

 > - In this context we know it's RR type, so I'd say "Unrecognized RR
 >   type string":
 > {{{#!cpp
 >     if (!RRParamRegistry::getRegistry().textToTypeCode(type_str,
 typecode_)) {
 >         isc_throw(InvalidRRType,
 >                   "Unrecognized RR parameter string: " + type_str);
 >     }
 > }}}
 >   For that matter, same point applies to the RRClass constructor.

 Both are updated now.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2565#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development