BIND 10 #2565: Refactor RR param parsing code in MasterLoader
BIND 10 Development
do-not-reply at isc.org
Mon Dec 31 04:16:12 UTC 2012
#2565: Refactor RR param parsing code in MasterLoader
-------------------------------------+-------------------------------------
Reporter: muks | Owner: muks
Type: enhancement | Status:
Priority: medium | closed
Component: libdns++ | Milestone:
Keywords: | Sprint-20130108
Sensitive: 0 | Resolution: fixed
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 1
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* status: reviewing => closed
* resolution: => fixed
Comment:
Merged to `master` branch in commit
`bef01123fb5dfaee927bc58da465109240811a18`:
{{{
* 025db8d [2565] Update comment about exception overhead
* 00845ee [2565] Specify parameter kind in exception messages
* 080d47d [2565] Add rationale for why bool is returned instead of
throwing an exception
* 9f5102a [2565] Rename constructor arguments to look nicer
* 0758ead [2565] Update textToTypeCode() to match textToClassCode()
* 9ab7213 [2565] Rename function argument
* ffe973e [2565] Fix indenting and untabify
* 857d7fb [2565] Fix exception message returned when classes don't match
* 514b87c [2565] Throw InternalException instead of isc::BadValue
* 6d28690 [2565] Use the wrapped RRClass directly, in the comparison
* 029be67 [2565] Fix grammar in methods' documentation
* 5ec876c [2565] style cleanups: constify; combine short lines
* 09dc37b [2565] constify
* b0bc2d3 [2565] Use boost::optional in the newly introduced RRClass
factory
* 1b69710 [2565] Add proto for RRClass::fromText()
* 4d6495a [2565] Avoid redundant construction in parseRRParams()
* 530e62b [2565] Add RRClass.fromText()
* ed7622d [2565] Refactor code so that RRParamRegistry::textToClassCode()
does not throw
}}}
Resolving as fixed. Thank you for the reviews Jinmei.
--
Ticket URL: <http://bind10.isc.org/ticket/2565#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list