BIND 10 #1595: Make the share name configurable

[BIND 10 Development]

#1595: Make the share name configurable
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120221
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:         |           Total Hours:  0
  Socket creator, multiple auths     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 vorner]:

 It basically looks okay.  I have a few minor comments (below), but I
 don't think we need an additional review cycle for them.  Please
 address (or not) them in the way you think appropriate, and merge.

 - I'd use uppercased variable names for constants (also as noted in
   the coding guideline): s/auth_name/AUTH_NAME/,
   s/resolver_name/RESOLVER_NAME/
 - I'd add one more const to these variables:
 {{{
 extern const char* const AUTH_NAME;
 }}}
   etc.
 - a few nits to the additional comments to socket_request.h:
   - s/a FD/an FD/ for consistency (or use "a" consistently)
   - s/same share name as we/same share name as ours/?  ...and as I
     wrote it I remembered Jelte didn't like we/us etc in reference
     documentation.  I don't have a strong opinion on this point, but I
     see it sounds a bit awkward, so maybe "same share name as that of
     this process" or something?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1595#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development