BIND 10 #1641: Further bug(s) in NSEC3 RDATA implementation

[BIND 10 Development]

#1641: Further bug(s) in NSEC3 RDATA implementation
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  accepted
                       Type:         |             Milestone:
  defect                             |  Sprint-20120221
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac1641 is ready for review.

 As I expected I've found a number of other bugs (though most of them
 are minor).  I fixed all of them in the ticket.

 The diff may look big, but important parts are changes up to 5c49671
 (inclusive).  They generally consist of more tests in
 rdata_nsecbitmap_unittest.cc and misc. bug fixes in the NSEC3
 implementation.  nsecbitmap_unittest was also heavily modified so we
 use TYPED_TEST to share essentially same tests for NSEC and NSEC3, but
 otherwise it should be quite straightforward.

 f10604e and d9640f6 are after-work cleanup: unified the same code
 logic for handling NSEC/NSEC3 bitmaps.  So, even if the amount of
 change may be big, it should be essentially trivial.

 This is the proposed changelog entry:
 {{{
 377.?   [bug]           jinmei
         libdns++: miscellaneous bug fixes for the NSEC and NSEC3 RDATA
         implementation, including a crash in NSEC3::toText() for some RR
         types, incorrect handling of empty NSEC3 salt, and incorrect
         comparison logic in NSEC3::compare().
         (Trac #1641, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1641#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development