BIND 10 #1641: Further bug(s) in NSEC3 RDATA implementation

[BIND 10 Development]

#1641: Further bug(s) in NSEC3 RDATA implementation
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120221
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 > Do you mean descriptive comments by "a header"? I added some.
 Yes and it is what I was after, thanks.

 >> bitmapsToText: "continue"s can be avoided by inverting the sense of the
 tests.
 > :
 That is what I meant and admittedly it is a bit subjective.

 > Also, this implementation is a quite straightforward port of BIND 9's
 implementation, and these "continue"s are derived from BIND 9, too.
 In that case keep it as is.

 > If you mean replacing:
 > :
 > then we cannot do this because it will incorrectly return 0 if cmplen...
 Doh! Missed the case where memcmp() returns 0.

 All OK, please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1641#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development