BIND 10 #1583: auth::Query NSEC3 support: Wildcard no data case
BIND 10 Development
do-not-reply at isc.org
Tue Feb 14 01:56:38 UTC 2012
#1583: auth::Query NSEC3 support: Wildcard no data case
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: accepted
Type: task | Milestone:
Priority: major | Sprint-20120221
Component: | Resolution:
b10-auth | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
trac1583 is ready for review.
This is basically a straightforward implementation of the ticket
description.
I've made one, not directly related extension to Message::addRRset()
(commit bc105b5): reject null rrset with an exception. There should
be no valid case of passing a null pointer to this method (but we
still want to pass it by pointer so we can use it in an STL-like
container), so rejecting such cases should make sense anyway. And, it
will help simplify the query processing logic because then it wouldn't
have to worry about buggy data source implementation that returns null
RRset when the API says it shouldn't.
I saw a slight possibility of refactoring existing parts of NSEC3 to
unify common patterns, but at the moment the amount of code is not
that much, so I decided to defer it to the cleanup ticket, #1587.
--
Ticket URL: <http://bind10.isc.org/ticket/1583#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list