BIND 10 #1580: auth::Query NSEC3 support: Name Error case

[BIND 10 Development]

#1580: auth::Query NSEC3 support: Name Error case
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120221
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  4
Feature Depending on Ticket:  NSEC3  |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Initial feedback:

 - I've made trivial editorial cleanups.  In particular, redundant
   white spaces at end of lines should be easily identifiable if (e.g)
   using colored output of git.  I'd suggest you perform this level of
   checks before asking for review.
 - The code seems naively copies comments from the NSEC counterpart,
   many of which are not applicable to the NSEC3 case.  Please go
   through the comments and make sure they make sense in the context.
 - in addNSEC3NXDOMAINProof, the case where next_proof is NULL must be
   explicitly rejected (and tested)
 - related to the previous point, tests are insufficient.  They should
   cover failure cases.
 - This is not correct:
 {{{#!c++
     const Name wildname(Name("*").concatenate(qname_.split(1)));
 }}}
   Consider the case where the wildcard is *.example.com and qname is
   a.b.example.com.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1580#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development