BIND 10 #1668: redo threaded stats tests with mocksessions

BIND 10 Development do-not-reply at isc.org
Tue Feb 14 11:00:19 UTC 2012


#1668: redo threaded stats tests with mocksessions
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:
                       Type:  task   |                Status:  new
                   Priority:  major  |             Milestone:  Year 3 Task
                  Component:         |  Backlog
  statistics                         |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 As long as I just saw a bit of b10-stats_test.py, will it work if we
 explicitly close the already opened ModuleCCSession object before we newly
 set the MockModuleCCSession object? For example,
 {{{
 --- a/src/bin/stats/tests/b10-stats_test.py
 +++ b/src/bin/stats/tests/b10-stats_test.py
 @@ -207,7 +207,8 @@ class TestStats(unittest.TestCase):
          # below), are temporarily disabled
          # See ticket #1668
          # Override moduleCCSession so we can check if send_stopping is
 called
 -        #self.stats.mccs = MockModuleCCSession()
 +        self.stats.mccs.close()
 +        self.stats.mccs = MockModuleCCSession()
          self.assertEqual(send_shutdown("Stats"), (0, None))
          self.assertFalse(self.stats.running)
          # Call server.shutdown with argument True so the thread.join()
 call
 }}}
 But I don't at all test the above.
 Regards,

-- 
Ticket URL: <http://bind10.isc.org/ticket/1668#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list