BIND 10 #1638: NSEC3PARAM rdata should have more tests

[BIND 10 Development]

#1638: NSEC3PARAM rdata should have more tests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  accepted
                       Type:         |             Milestone:
  defect                             |  Sprint-20120221
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac1638 is ready for review.

 The diff is large, but many parts of it should be quite
 straightforward refactoring:

 - The first commit (a2bc586) is to convert some of NSEC3 tests to
   TYPED_TESTs so they can be shared with NSEC3PARAM.  The diff of this
   commit is large, but should be straightforward.
 - 95b8b13 to 6292462 (inclusive) are the main part of the branch.
   They fix a number of bugs in the NSEC3PARAM implementation so that
   it will pass the shared tests.  Some new tests were added.
 - bf67156 is an independent (and not directly related) bug fix to
   NSEC3 I happened to notice during the work.
 - 001717c is to unify common (and reasonably complicated) code logic
   for NSEC3 and NSEC3PARAM into a single (essentially private) helper
   module.  The diff of this commit is large, but essentially it should
   be straightforward.

 One final note: distcheck fails due to unrelated bug I pushed to
 master with #1641.  Cherry-picking 8c5e01a will solve it (I confirmed
 distcheck passed for this branch with it), but I didn't merge it to
 the branch to avoid confusion.

 This is the proposed changelog entry:
 {{{
 378.?   [bug]           jinmei
         libdns++: miscellaneous bug fixes for the NSECPARAM RDATA
         implementation, including incorrect handling for empty salt and
         incorrect comparison logic.
         (Trac #1638, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1638#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development